alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
A couple of nits. Please address Aaron's comment as well.
================
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:53
+ for (const auto &NoExceptRange : NoExceptRanges) {
+ // FIXME use DiagnosticIDs::Level::Note
+ diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
----------------
nit: remove the FIXME
================
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+ // FIXME use DiagnosticIDs::Level::Note
+ diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+ << FixItHint::CreateRemoval(NoExceptRange);
----------------
nit: `nothrow` (without a dash), no colon needed (it will look weird, since the
location is mentioned _before_ the message, not after it)
https://reviews.llvm.org/D19201
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
