aaron.ballman added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/safety/NoAssemblerCheck.cpp:13 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Lexer.h" + ---------------- Is this include needed? ================ Comment at: clang-tools-extra/clang-tidy/safety/NoAssemblerCheck.cpp:36 +void NoAssemblerCheck::check(const MatchFinder::MatchResult &Result) { + Optional<SourceLocation> ASMLocation; + if (const auto *ASM = Result.Nodes.getNodeAs<AsmStmt>("asm-stmt")) ---------------- No need for this to be an `Optional`, is there? https://reviews.llvm.org/D29267 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits