idlecode added a comment. Indeed, thanks :) I ran `make check-all` and had no errors so I thought there are no tests.
================ Comment at: lib/Frontend/CompilerInvocation.cpp:1709 + Diags.Report(diag::note_drv_supported_value_with_description) + << Std.getName() << Std.getDescription(); + } ---------------- ahatanak wrote: > Is it possible to change the diagnostic so that it's easier to tell which > part is the supported value and which part is the description? > > The diagnostic looks like this, and I found it a little hard to tell at a > quick glance: > > "c89 - ISO C 1990" Sure, I have tried few formats with quotes/colons but how about this (a bit verbose) version: ``` note: supported values are: note: 'c89' for standard 'ISO C 1990' note: 'c90' for standard 'ISO C 1990' note: 'iso9899:1990' for standard 'ISO C 1990' ... ``` What do you think about it? Do you have any suggestions? https://reviews.llvm.org/D29724 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
