joerg requested changes to this revision. joerg added inline comments. This revision now requires changes to proceed.
================ Comment at: lib/CodeGen/CodeGenModule.cpp:2402 + return GetOrCreateLLVMGlobal(Name, llvm::PointerType::getUnqual(Ty), nullptr, + NotForDefinition, Hidden); } ---------------- Can't this use the VarDecl argument of GetOrCreateLLVMGlobal to set the visibility? I'd prefer to keep reundant arguments to a minimum. https://reviews.llvm.org/D29843 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
