carlosgalvezp wrote: > but these are not internal implementation details - these are key elements of > the public API
In the unit test, you have copied internal code from here: https://github.com/google/googletest/blob/d144031940543e15423a25ae5a8a74141044862f/googletest/include/gtest/internal/gtest-internal.h#L1477 This is not OK to do, since it may change at any time and make the test no longer useful. The test may also work for some versions of googletest but not others. The code that has been copied is also Copyrighted and has certain License obligations, which we may not be allowed to bring into the LLVM repository. https://github.com/llvm/llvm-project/pull/115051 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
