arphaman added inline comments.
================ Comment at: lib/CodeGen/CodeGenPGO.cpp:631 + ((isa<CXXConstructorDecl>(D) && GD.getCtorType() != Ctor_Base && + !cast<CXXConstructorDecl>(D)->getParent()->getNumVBases()) || (isa<CXXDestructorDecl>(D) && GD.getDtorType() != Dtor_Base))) { ---------------- I think it would be more appropriate to use the `IsConstructorDelegationValid` static function from `CGClass.cpp` instead of using the `numVBases` check, as some virtual inheritance constructors might get delegated in the future (as stated in the comments inside of `IsConstructorDelegationValid`). https://reviews.llvm.org/D30131 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits