djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.

Would probably be interesting to add these test cases:

  #if A
  namespace A {
  #else
  namespace B {
  #endif
  int i;
  int j;
  }//namespace A

and:

  namespace A {
  int i;
  int j;
  #if A
  }//namespace A
  #else
  }//namespace A
  #endif



================
Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:139
+    FormatToken *RBraceTok = EndLine->First;
+    if (RBraceTok->Finalized) continue;
+    RBraceTok->Finalized = true;
----------------
Use clang-format :). (there should be a linebreak before "continue".


https://reviews.llvm.org/D30659



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to