https://github.com/Lukacma commented:
Thank you for the patch Carol ! On top of comments I left I think we should also add new runlines to both assembly tests for individual instructions and instrinsics tests, to check that we produce correct assembly when ssve-bitperm feature is used. Also I think we should update TargetParserTest.cpp and tests for dependencies of new ssve-bitperm feature. https://github.com/llvm/llvm-project/pull/121947 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits