EricWF added a comment.
This LGTM, but I don't know enough Clang to be 100% on it. Perhaps somebody
else could give it a quick second look?
================
Comment at: lib/Sema/SemaCoroutine.cpp:157
+ if (S.RequireCompleteType(Loc, CoroHandleType,
+ diag::err_coroutine_traits_missing_specialization))
+ return QualType();
----------------
Should this diagnostic be renamed since it's general to both `coroutine_traits`
and `coroutine_handle`?
================
Comment at: test/SemaCXX/coroutines.cpp:540
+ //expected-note@-1 {{call to 'initial_suspend' implicitly required by the
initial suspend point}}
+ //expected-note@+1 {{function is a coroutine due to use of 'co_return' here}}
+ co_return;
----------------
Nit, put the `// expected-note` directly on the `co_return` line.
https://reviews.llvm.org/D26316
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
