Anastasia added inline comments.
================ Comment at: lib/Driver/Tools.cpp:5288 // parser. - Args.AddAllArgValues(CmdArgs, options::OPT_Xclang); + if (C.getDriver().isSaveTempsEnabled() && + !isa<PreprocessJobAction>(JA)) { ---------------- It would be nice to add a comment around here explaining this case. ================ Comment at: lib/Driver/Tools.cpp:5290 + !isa<PreprocessJobAction>(JA)) { + //Args.AddAllArgValues(CmdArgs, options::OPT_Xclang); + for (auto Arg : Args.filtered(options::OPT_Xclang)) { ---------------- Remove the commented code, please! https://reviews.llvm.org/D30743 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits