krasimir added inline comments.
================
Comment at: clangd/clients/clangd-vscode/package.json:45
+ "default": "clangd",
+ "description": "The path to clangd executable"
+ },
----------------
Maybe prepend a `, for example: /usr/bin/clangd` to the "description".
================
Comment at: clangd/clients/clangd-vscode/src/extension.ts:19
export function activate(context: vscode.ExtensionContext) {
- // TODO: make this configurable
- const clangdPath = '/usr/bin/clangd';
+ const clangdPath = getConfig<string>('path', '/usr/bin/clangd');
+ const clangdArgs = getConfig<string[]>('arguments', []);
----------------
I feel that this is too platform-specific and redundant because "clangd.path"
already has a default value.
https://reviews.llvm.org/D31121
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
