This revision was automatically updated to reflect the committed changes. Closed by commit rL298697: [libclang] Bury dead TemporaryFiles (authored by krasimir).
Changed prior to commit: https://reviews.llvm.org/D31288?vs=92804&id=92908#toc Repository: rL LLVM https://reviews.llvm.org/D31288 Files: cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp Index: cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp =================================================================== --- cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp +++ cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp @@ -270,10 +270,6 @@ /// \brief Source manager, used for diagnostics. IntrusiveRefCntPtr<SourceManager> SourceMgr; - /// \brief Temporary files that should be removed once we have finished - /// with the code-completion results. - std::vector<std::string> TemporaryFiles; - /// \brief Temporary buffers that will be deleted once we have finished with /// the code-completion results. SmallVector<const llvm::MemoryBuffer *, 1> TemporaryBuffers; @@ -335,8 +331,6 @@ llvm::DeleteContainerPointers(DiagnosticsWrappers); delete [] Results; - for (unsigned I = 0, N = TemporaryFiles.size(); I != N; ++I) - llvm::sys::fs::remove(TemporaryFiles[I]); for (unsigned I = 0, N = TemporaryBuffers.size(); I != N; ++I) delete TemporaryBuffers[I];
Index: cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp =================================================================== --- cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp +++ cfe/trunk/tools/libclang/CIndexCodeCompletion.cpp @@ -270,10 +270,6 @@ /// \brief Source manager, used for diagnostics. IntrusiveRefCntPtr<SourceManager> SourceMgr; - /// \brief Temporary files that should be removed once we have finished - /// with the code-completion results. - std::vector<std::string> TemporaryFiles; - /// \brief Temporary buffers that will be deleted once we have finished with /// the code-completion results. SmallVector<const llvm::MemoryBuffer *, 1> TemporaryBuffers; @@ -335,8 +331,6 @@ llvm::DeleteContainerPointers(DiagnosticsWrappers); delete [] Results; - for (unsigned I = 0, N = TemporaryFiles.size(); I != N; ++I) - llvm::sys::fs::remove(TemporaryFiles[I]); for (unsigned I = 0, N = TemporaryBuffers.size(); I != N; ++I) delete TemporaryBuffers[I];
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits