EricWF added a comment.

OK, so ABI wise this seems good. I'll need a fresh head to review the locale 
changes for correctness. I'll get around to that tomorrow.



================
Comment at: libcxx/include/locale:891
 
+#ifndef _LIBCPP_ABI_OPTIMIZED_LOCALE
 // signed
----------------
Would it be possible to reduce the amount of duplicate code between the two 
implementations? Currently it seems like there is a lot.


https://reviews.llvm.org/D30268



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to