Hahnfeld added inline comments.
================ Comment at: lib/Driver/ToolChains/CommonArgs.cpp:430 +bool tools::addOpenMPRuntime(ArgStringList &CmdArgs, const ToolChain &TC, + const ArgList &Args, const JobAction &JA, + bool GompNeedsRT) { ---------------- ABataev wrote: > Do you really need to pass a reference to `JobAction` here or it is enough to > pass a bool value for `JA.isHostOffloading()`? Good idea, this even allows this change to become fully NFC https://reviews.llvm.org/D30087 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits