a.sidorin added inline comments.
================ Comment at: lib/AST/ASTImporter.cpp:4305 + DeclarationNameInfo NameInfo(Name, Importer.Import(D->getNameInfo().getLoc())); + ImportDeclarationNameLoc(D->getNameInfo(), NameInfo); + ---------------- spyffe wrote: > I've seen this pattern before, in [[ https://reviews.llvm.org/D27033 | D20733 > ]], at ASTImporter.cpp:6488: > ``` > DeclarationNameInfo NameInfo(E->getName(), E->getNameLoc()); > ImportDeclarationNameLoc(E->getNameInfo(), NameInfo); > ``` > That code didn't do the `Import` during the initialization of the > `DeclarationNameInfo`. Is either of these incorrect? This may come from our published code but it looks like an issue that needs to be fixed. Thank you for spotting this. https://reviews.llvm.org/D27181 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
