Author: vvassilev Date: Tue Apr 11 11:05:23 2017 New Revision: 299956 URL: http://llvm.org/viewvc/llvm-project?rev=299956&view=rev Log: Revert temporarily D29877 "Warn about unused static file scope function template declarations."
We need to address cases (breaking libc++) such as template <class _Up> static int __test(...); template<typename _Tp> auto v = __test<_Tp>(0); Modified: cfe/trunk/lib/Sema/Sema.cpp cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/SemaCXX/warn-unused-filescoped.cpp Modified: cfe/trunk/lib/Sema/Sema.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema.cpp?rev=299956&r1=299955&r2=299956&view=diff ============================================================================== --- cfe/trunk/lib/Sema/Sema.cpp (original) +++ cfe/trunk/lib/Sema/Sema.cpp Tue Apr 11 11:05:23 2017 @@ -470,13 +470,6 @@ static bool ShouldRemoveFromUnused(Sema return true; if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) { - // If this is a function template and none of its specializations is used, - // we should warn. - if (FunctionTemplateDecl *Template = FD->getDescribedFunctionTemplate()) - for (const auto *Spec : Template->specializations()) - if (ShouldRemoveFromUnused(SemaRef, Spec)) - return true; - // UnusedFileScopedDecls stores the first declaration. // The declaration may have become definition so check again. const FunctionDecl *DeclToCheck; @@ -500,13 +493,6 @@ static bool ShouldRemoveFromUnused(Sema VD->isUsableInConstantExpressions(SemaRef->Context)) return true; - if (VarTemplateDecl *Template = VD->getDescribedVarTemplate()) - // If this is a variable template and none of its specializations is used, - // we should warn. - for (const auto *Spec : Template->specializations()) - if (ShouldRemoveFromUnused(SemaRef, Spec)) - return true; - // UnusedFileScopedDecls stores the first declaration. // The declaration may have become definition so check again. const VarDecl *DeclToCheck = VD->getDefinition(); Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=299956&r1=299955&r2=299956&view=diff ============================================================================== --- cfe/trunk/lib/Sema/SemaDecl.cpp (original) +++ cfe/trunk/lib/Sema/SemaDecl.cpp Tue Apr 11 11:05:23 2017 @@ -8887,7 +8887,6 @@ Sema::ActOnFunctionDeclarator(Scope *S, if (FunctionTemplate) { if (NewFD->isInvalidDecl()) FunctionTemplate->setInvalidDecl(); - MarkUnusedFileScopedDecl(NewFD); return FunctionTemplate; } } @@ -10988,7 +10987,8 @@ static bool hasDependentAlignment(VarDec /// FinalizeDeclaration - called by ParseDeclarationAfterDeclarator to perform /// any semantic actions necessary after any initializer has been attached. -void Sema::FinalizeDeclaration(Decl *ThisDecl) { +void +Sema::FinalizeDeclaration(Decl *ThisDecl) { // Note that we are no longer parsing the initializer for this declaration. ParsingInitForAutoVars.erase(ThisDecl); @@ -11153,8 +11153,9 @@ void Sema::FinalizeDeclaration(Decl *Thi if (DC->getRedeclContext()->isFileContext() && VD->isExternallyVisible()) AddPushedVisibilityAttribute(VD); - // FIXME: Warn on unused var template partial specializations. - if (VD->isFileVarDecl() && !isa<VarTemplatePartialSpecializationDecl>(VD)) + // FIXME: Warn on unused templates. + if (VD->isFileVarDecl() && !VD->getDescribedVarTemplate() && + !isa<VarTemplatePartialSpecializationDecl>(VD)) MarkUnusedFileScopedDecl(VD); // Now we have parsed the initializer and can update the table of magic Modified: cfe/trunk/test/SemaCXX/warn-unused-filescoped.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-unused-filescoped.cpp?rev=299956&r1=299955&r2=299956&view=diff ============================================================================== --- cfe/trunk/test/SemaCXX/warn-unused-filescoped.cpp (original) +++ cfe/trunk/test/SemaCXX/warn-unused-filescoped.cpp Tue Apr 11 11:05:23 2017 @@ -1,5 +1,5 @@ // RUN: %clang_cc1 -fsyntax-only -verify -Wunused -Wunused-member-function -Wno-unused-local-typedefs -Wno-c++11-extensions -std=c++98 %s -// RUN: %clang_cc1 -fsyntax-only -verify -Wunused -Wunused-member-function -Wno-unused-local-typedefs -std=c++14 %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wunused -Wunused-member-function -Wno-unused-local-typedefs -std=c++11 %s #ifdef HEADER @@ -65,7 +65,7 @@ namespace { template <> void TS<int>::m() { } // expected-warning{{unused}} template <typename T> - void tf() { } // expected-warning{{unused}} + void tf() { } template <> void tf<int>() { } // expected-warning{{unused}} struct VS { @@ -200,18 +200,6 @@ void bar() { void func() __attribute__(( static void func() {} } -namespace test9 { -template<typename T> -static void completeRedeclChainForTemplateSpecialization() { } // expected-warning {{unused}} -} - -namespace test10 { -#if __cplusplus >= 201103L -template<class T> -constexpr T pi = T(3.14); // expected-warning {{unused}} -#endif -} - namespace pr19713 { #if __cplusplus >= 201103L // FIXME: We should warn on both of these. _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits