Hahnfeld added a comment. Is there a way to actually test the changed code? The current test changes seem unrelated...
================ Comment at: include/clang/Basic/DiagnosticDriverKinds.td:165-166 "The target '%0' is not a supported OpenMP host target.">; +def err_drv_omp_device_target_not_supported : Error< + "The target '%0' is not a supported OpenMP device target.">; def err_drv_expecting_fopenmp_with_fopenmp_targets : Error< ---------------- This diagnostic seems unrelated to the code. ================ Comment at: test/OpenMP/target_messages.cpp:7-8 // CHECK-UNSUPPORTED-HOST-TARGET: error: The target '{{nvptx64-nvidia-cuda|nvptx-nvidia-cuda}}' is not a supported OpenMP host target. +// RUN: not %clang_cc1 -fopenmp -std=c++11 -fopenmp-targets=hexagon-linux-gnu -o - %s 2>&1 | FileCheck --check-prefix CHECK-UNSUPPORTED-DEVICE-TARGET %s +// CHECK-UNSUPPORTED-DEVICE-TARGET: The target 'hexagon-linux-gnu' is not a supported OpenMP device target. ---------------- This test seems unrelated to the changes to the code. Repository: rL LLVM https://reviews.llvm.org/D29658 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits