https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/133776
While clangCodeGenTargetBuiltins and clangCodeGenTargets are static libraries clangCodeGen is not and so this is creating a circular reference in the linux amdgpu-offload CIs on ubuntu and RHEL. removing the circular reference doesn't break anything and looks to be a vestigial element of the origional PR. >From a46aa12ffb7a15bc165b86a6b58c33898792096b Mon Sep 17 00:00:00 2001 From: Farzon Lotfi <farzonlo...@microsoft.com> Date: Mon, 31 Mar 2025 14:42:00 -0400 Subject: [PATCH] [CMAKE][AMDGPU] fix build failure caused by PR #133619 While clangCodeGenTargetBuiltins and clangCodeGenTargets are static libraries clangCodeGen is not and so this is creating a circular reference in the linux amdgpu-offload CIs on ubuntu and RHEL. removing the circular reference doesn't break anything and looks to be a vestigial element of the origional PR. --- clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt | 5 ----- clang/lib/CodeGen/Targets/CMakeLists.txt | 5 ----- 2 files changed, 10 deletions(-) diff --git a/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt b/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt index 8526c063b4593..76be68a11d02a 100644 --- a/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt +++ b/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt @@ -12,8 +12,3 @@ add_clang_library(clangCodeGenTargetBuiltins STATIC WebAssembly.cpp X86.cpp ) - -target_link_libraries(clangCodeGenTargetBuiltins - PRIVATE - clangCodeGen -) diff --git a/clang/lib/CodeGen/Targets/CMakeLists.txt b/clang/lib/CodeGen/Targets/CMakeLists.txt index fd79b6191b379..6b6e7ce5b0b29 100644 --- a/clang/lib/CodeGen/Targets/CMakeLists.txt +++ b/clang/lib/CodeGen/Targets/CMakeLists.txt @@ -28,8 +28,3 @@ add_clang_library(clangCodeGenTargets STATIC X86.cpp XCore.cpp ) - -target_link_libraries(clangCodeGenTargets - PRIVATE - clangCodeGen -) _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
