rsmith added a comment.

From some very superficial testing, it looks like CL treats 
`__declspec(inline)` exactly like a synonym for `inline` (it even rejects them 
both appearing on the same declaration, complaining about a duplicate `inline` 
specifier). So modeling this as `GNUInlineAttr` is definitely wrong, and this 
should probably be setting the `inline` flag on the function. But I agree with 
Aaron: we need some evidence that implementing this in Clang is worthwhile 
(rather than changing the codebase to use the `inline` keyword instead). We aim 
to be CL-compatible for common code patterns, not to be 100% compatible with 
all code that CL accepts.


https://reviews.llvm.org/D32092



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to