[clang] [clang-tools-extra] [clang] fix diagnostic printing of expressions ignoring LangOpts (PR #134693)

[Erich Keane via cfe-commits]

================
@@ -493,8 +493,8 @@ DeduceNullPtrTemplateArgument(Sema &S, 
TemplateParameterList *TemplateParams,
                                                         : CK_NullToPointer)
                     .get();
   return DeduceNonTypeTemplateArgument(
-      S, TemplateParams, NTTP, DeducedTemplateArgument(Value), 
Value->getType(),
----------------
erichkeane wrote:

Ah!  I see, thanks.  So so we went from:

`DeducedTemplateArgument(TemplateArgument{implicit}(Value))`

to 
`DeducedTemplateArgument{implicit}(TemplateArgument(Value))`

That seems fine to me.  I'd probably prefer it be explicit, but don't feel 
strongly enough on this one to push back more than this

https://github.com/llvm/llvm-project/pull/134693
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits