hfinkel added a comment. In https://reviews.llvm.org/D31885#730728, @kparzysz wrote:
> In https://reviews.llvm.org/D31885#730038, @hfinkel wrote: > > > I'm somewhat concerned that this patch is quadratic in the AST. > > > I'd be happy to address this, but I'm not sure how. Memoizing results could > be one way, but don't know if that's acceptable. > > This location in codegen seems to be the last place where the original C/C++ > types are available, in particular the information as to whether a type is a > union or not. Maybe it would be possible to propagate some bit somewhere, > but then this patch would become much less localized. I'm not worried particularly about localization because we want to extend TBAA to support unions, etc. anyway. I suppose I don't understand how the propagation that is necessary here differs from what is necessary to propagate the base-type information for structs. Repository: rL LLVM https://reviews.llvm.org/D31885 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
