Markus =?utf-8?q?Gschoßmann?= <markus.gschossm...@tum.de>, Markus =?utf-8?q?Gschoßmann?= <markus.gschossm...@tum.de>, Markus =?utf-8?q?Gschoßmann?= <markus.gschossm...@tum.de>, Markus =?utf-8?q?Gschoßmann?= <markus.gschossm...@tum.de> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/130...@github.com>
================ @@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -triple x86_64-none-linux-gnu -emit-llvm -debug-info-kind=limited %s -o - | FileCheck %s ---------------- mgschossmann wrote: The key change of this pull request is that debug info for destructors is now taken from `FNType` instead of `D->getType()` / `Method->getType()`. `Method->getType()` does not include the implicit arguments, while `FNType` does. `FNType` however also includes the `this` argument. In order to prevent duplicate emission of `this`, the pull request introduces the `SkipFirst` argument in `getOrCreateInstanceMethodType`. I now also added a test for MSVC, which checks for presence of the `should_call_delete` arg. It also enforces that the return value be `void*`. The new test seems to pass, however there seems to be an issue in the CI, so it is reported as failed. https://github.com/llvm/llvm-project/pull/130674 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
