ABataev added inline comments.

================
Comment at: lib/Driver/ToolChains/Cuda.cpp:297
+      !Args.hasFlag(options::OPT_fnoopenmp_relocatable_target,
+                    options::OPT_fopenmp_relocatable_target, false))
     CmdArgs.push_back("-c");
----------------
1. Add a comment with the name of the parameter for `false` argument
2. Why not to use this logic:
```
Args.hasFlag(options::OPT_fopenmp_relocatable_target,
                    options::OPT_fnoopenmp_relocatable_target, true)
```
?


Repository:
  rL LLVM

https://reviews.llvm.org/D29659



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D29659: [Op... Gheorghe-Teodor Bercea via Phabricator via cfe-commits
    • [PATCH] D29659... Alexey Bataev via Phabricator via cfe-commits
    • [PATCH] D29659... Gheorghe-Teodor Bercea via Phabricator via cfe-commits
    • [PATCH] D29659... Alexey Bataev via Phabricator via cfe-commits

Reply via email to