smeenai added inline comments.
================
Comment at: CMakeLists.txt:119
+ set(LIBCXX_CXX_ABI_LIBNAME "vcruntime")
else()
+ find_path(
----------------
EricWF wrote:
> Nit: I would rather see this be
> ```
> elseif ((NOT LIBCXX_STANDALONE_BUILD OR HAVE_LIBCXXABI) AND
> IS_DIRECTORY "${LIBCXX_LIBCXXABI_INCLUDES_INTERNAL}")
> ```
>
> That way we can avoid a level of nesting.
Sounds good; will change before committing.
https://reviews.llvm.org/D32320
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
