efriedma-quic wrote: > Effectively checking for `LangOpts.DollarIdents || LangOpts.AsmPreprocessor`? > Or do you think `DollarIdents` should be true if `AsmPreprocessor` is true?
Neither. DollarIdents is already off by default in AsmPreprocessor mode. We should just preserve the existing behavior, and not warn. --- (I'm not I really understand all the standards-committee stuff, but it seems dubious to have the semantics of $ in preprocessor macros implementation-defined.) https://github.com/llvm/llvm-project/pull/135407 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
