https://github.com/frasercrmck approved this pull request.

LGTM.

I see there's a note in the spec: `async_work_group_copy and 
async_work_group_strided_copy for 3-component vector types behave as 
async_work_group_copy and async_work_group_strided_copy respectively for 
4-component vector types. `. I'm not sure what that really means for our 
implementation which does a loop and a store.

I also wonder why we have `async/gentype.inc`. With this change, couldn't we 
just use `float/gentype.inc` and `integer/gentype.inc` in succession?

https://github.com/llvm/llvm-project/pull/137932
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to