NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
Looks good, thanks! Did you evaluate this on a large codebase - were warnings plentiful and were there any false positives known? I'd like to summon Anna here for a little bit because that's a new check that is enabled by default, so it's always a bit of a historical moment: - Does the warning message sound reasonable? (it does to me). - Should we keep it as part of the unix.Malloc checker package, or should we be able to enable it separately? Repository: rL LLVM https://reviews.llvm.org/D31650 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits