yamaguchi marked 2 inline comments as done.
yamaguchi added inline comments.
================
Comment at: lib/Sema/SemaInit.cpp:892
+ SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc);
+ if (!(SpellingLoc.isValid() &&
+ SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))) {
----------------
v.g.vassilev wrote:
> I'd avoid double negations. Could you use `isInvalid` instead of `!isValid`.
> That would make the condition more readable.
It's not (!SpellingLoc.isValid()) but is !((SpellingLoc.isValid() &&
SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))
https://reviews.llvm.org/D32646
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
