================
@@ -111,6 +111,7 @@ def EnumConversion : DiagGroup<"enum-conversion",
                                 ImplicitEnumEnumCast,
                                 EnumFloatConversion,
                                 EnumCompareConditional]>;
+def ImplicitUnicodeConversion : DiagGroup<"implicit-unicode-conversion">;
----------------
tahonermann wrote:

I'd like to suggest "suspicious-character-comparison" or 
"suspicious-character-conversion" as the name of the diagnostic group. 
"implicit" doesn't provide any differentiation here since such mixed type 
comparisons necessarily involve an implicit conversion. These warnings seem 
applicable to the non-Unicode character types too, so I'd like to see "unicode" 
removed even if warnings won't be issued for those types in the near term.

https://github.com/llvm/llvm-project/pull/138708
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to