kadircet wrote: I'd like to highlight that many tools still only care about declarations themselves and not the attributes.
The ones that fiddle with attributes need to do it in a special and complicated way already. Making this less complicated definitely creates some value. But I think the immediate issue isn't about making that easy, but rather keeping most tools that don't care about attributes simple. Hence I think having consistency in source ranges associated with declarations to eliminate special cases in most tools is more beneficial (and possibly simpler). I'd probably lean towards keeping them out of the source ranges associated with decls, as that's the current state of the world. Unless we're deliberately going to include them in declarations source range's systematically, I think we're more likely to regress users down the line. https://github.com/llvm/llvm-project/pull/133107 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
