================
@@ -2779,13 +2779,47 @@ void 
CodeGenFunction::EmitTypeMetadataCodeForVCall(const CXXRecordDecl *RD,
   }
 }
 
+std::pair<SanitizerKind::SanitizerOrdinal, llvm::SanitizerStatKind>
+CodeGenFunction::ParseCFITypeCheckKind(CFITypeCheckKind TCK) {
+  SanitizerKind::SanitizerOrdinal M;
+  llvm::SanitizerStatKind SSK;
+
+  switch (TCK) {
+  case CFITCK_VCall:
+    M = SanitizerKind::SO_CFIVCall;
----------------
delcypher wrote:

Why not just `return std::make_pair(SanitizerKind::SO_CFIVCall, 
llvm::SanStat_CFI_VCall)`?  It's a little more concise and also inline with 
LLVM's coding style of returning as early as possible.

https://github.com/llvm/llvm-project/pull/139809
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to