chenwj added a comment. @erichkeane Just share what I investigated.
In https://reviews.llvm.org/D32759#744769, @erichkeane wrote: > In https://reviews.llvm.org/D32759#744613, @chenwj wrote: > > > > Ah, sorry. "Our Tests" means the lit test SemaObjC/method-bad-param.m > > > (line 11). I ran the lit tests initially with a breakpoint on this line > > > and it never hit, though I must have set up the debugger wrong. Once I > > > replaced it with an assert, method-bad-param failed. > > > > The fix LGTM. Is it possible to tweak method-bad-param.m so that we can see > > the difference after the fix? > > > I actually couldn't come up with a way where we COULD see the difference... > I was hoiping someone else could come up with something if it were important > enough for us. I fwd to @eli.friedman who added the check. Maybe he is the right person who can explain what's going on here, and decide if this patch is okay or not. https://reviews.llvm.org/D32759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
