balazske wrote: > > The problem was that nodes like `concepts::TypeRequirement` have > > constructors (and probably other related functions) defined in > > SemaConcepts.cpp. These can not be linked to the AST library, but are > > needed in `ASTImporter` for the new import functions. > > Can you try to move these to ExprCXX.cpp or ASTConcept.cpp? It would be much > cleaner
I can try it, I looked into this already but it seemed that there are more code dependencies and it is not a trivial task. Still I think that moving `ASTImporter` to the new component would be useful because it contains already too much code that can be split into more files, and in the future there may be again need to use functions of the Sema component (there is a similarity between building the AST by Sema and merging ASTs by `ASTImporter`). Probably we can open a (discourse) discussion about this? https://github.com/llvm/llvm-project/pull/140913 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
