ilovepi wrote: > Reading files from unit tests is a bit of an anti-pattern: It requires > putting the absolute path to the tests somewhere (you're doing this with a > config file here), and it means you easily run tests on a different machine > than the one you're building on. Could you restructure this test to not read > a file? Or, if you need to run a file, can you do that from a lit test, where > the path from build artifacts and test inputs is abstracted away enough that > the build/test separation still works?
I also don't really love the way this is shaped. We're trying to land functionality we want/need in clang-doc that a contributor more or less abandoned. Support to run the tool as a whole is further up the stack. I think it may be hard to reorder the patches to speed that up. As an alternative, we could disable the unit tests for the new feature, since its expected to be experimental for some time, and move the testing into lit tests. https://github.com/llvm/llvm-project/pull/138062 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
