================ @@ -1874,9 +1874,11 @@ ExprResult Sema::CreateGenericSelectionExpr( if (D != 0) { Diag(Types[i]->getTypeLoc().getBeginLoc(), D) - << Types[i]->getTypeLoc().getSourceRange() - << Types[i]->getType(); - TypeErrorFound = true; + << Types[i]->getTypeLoc().getSourceRange() << Types[i]->getType(); + if (getDiagnostics().getDiagnosticLevel( ---------------- erichkeane wrote:
Well, we're asking the De the 'level' not really 'did you/would you emit an error for this'. Leading me to believe we perhaps need some sort of `DiagnosticsEngine::isErrorDiagnostic` or something, but that is 1/2 baked here. BUT something we should find ourselves thinking about if this happens more often. https://github.com/llvm/llvm-project/pull/141596 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits