mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land.
In https://reviews.llvm.org/D33030#751723, @ahatanak wrote: > If field unwindHeader is annotated with the aligned attribute, both the field > and struct __cxa_exception are aligned. As a result, the exception object > that follows __cxa_exception is aligned too. > > If we annotate struct __cxa_exception with the attribute instead of > annotating the field, the test case segfaults. It seems that this approach > doesn't work because several places in cxa_exception.cpp assume the exception > object immediately follows field unwindHeader (there are should be no > paddings at the end of __cxa_exception). OK, then LGTM but add all these informations as a comment for unwindHeader field. https://reviews.llvm.org/D33030 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
