================ @@ -428,13 +422,28 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { return OpBuilder::InsertPoint(block, block->begin()); }; - mlir::IntegerAttr getSizeFromCharUnits(mlir::MLIRContext *ctx, - clang::CharUnits size) { - // Note that mlir::IntegerType is used instead of cir::IntType here - // because we don't need sign information for this to be useful, so keep - // it simple. - return mlir::IntegerAttr::get(mlir::IntegerType::get(ctx, 64), - size.getQuantity()); + // + // Alignement and size helpers + // + + // Note that mlir::IntegerType is used instead of cir::IntType here because we + // don't need sign information for these to be useful, so keep it simple. + + // Fot 0 alignment, return an empty attribute. ---------------- erichkeane wrote:
I don't get this comment, can you clarify? I don't see any SFINAE/etc for 0 alignment? Nor a condition to do so> https://github.com/llvm/llvm-project/pull/141830 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits