================
@@ -245,10 +247,32 @@ sortUsrToInfo(llvm::StringMap<std::unique_ptr<doc::Info>> 
&USRToInfo) {
   }
 }
 
+llvm::Error handleMappingPhaseErrors(llvm::Error Err,
----------------
ilovepi wrote:

This should be `static`. `handleMappingFailures()` makes more sense to me as an 
API name. Since IgnoreMappingFailures isn't a local, so you don't need to pass 
it in, since its visible to the whole file.

https://github.com/llvm/llvm-project/pull/141699
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to