https://github.com/vbvictor commented:
Left some general feedback, mostly docs/wording suggestions. For ease of review in the future, may you try to make `BoolBitwiseOperationCheck::check` function easier to read. E.g. extract some helper functions like `HasVolatileOrSideEffects`, `GetTranslatedSpelling` etc.. Mostly to cover noise of many `return` statements. https://github.com/llvm/llvm-project/pull/142324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
