https://github.com/tmatheson-arm approved this pull request.
Sorry for the slow responses, this has revealed some issues that we are not sure how to fix... I am happy with the patch as it is, it is a strict improvement for `reconstructFromParsedFeatures`. As @labrinea pointed out though, you should be aware that disabling SVE like this via `-Xclang` will bypass the driver, where the dependency tracking logic exists, and disable SVE only. Any subtarget features that depend on SVE (e.g. SVE2) will still be enabled, unless you explicitly disable them too. It is strongly advised to modify the `-march` flag instead. Also be aware that you can't (currently) rely on `--print-enabled-extensions` to give you an accurate view of what is enabled/disabled if you are manually adding `-target-feature` flags to the `-cc1` command. See #143570 for the details. https://github.com/llvm/llvm-project/pull/142236 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
