https://github.com/jansvoboda11 approved this pull request.

LGTM. I think I would slightly prefer for `DependencyScanningWorkerFilesystem` 
to accept the entire service instead of its members (for the same reasons we do 
that in the worker, action, etc.)

https://github.com/llvm/llvm-project/pull/144000
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to