https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/144244
None
>From 9ea5ce57ebb032faf0ee086e4574fc1424f76990 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <k...@google.com>
Date: Fri, 13 Jun 2025 09:06:58 -0700
Subject: [PATCH] [modularize] Use range-based for loops (NFC)
---
clang-tools-extra/modularize/CoverageChecker.cpp | 6 ++----
clang-tools-extra/modularize/Modularize.cpp | 4 ++--
clang-tools-extra/modularize/ModularizeUtilities.cpp | 3 +--
3 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/clang-tools-extra/modularize/CoverageChecker.cpp
b/clang-tools-extra/modularize/CoverageChecker.cpp
index fe6711398ab7d..1345a6ef8f489 100644
--- a/clang-tools-extra/modularize/CoverageChecker.cpp
+++ b/clang-tools-extra/modularize/CoverageChecker.cpp
@@ -329,10 +329,8 @@ bool CoverageChecker::collectFileSystemHeaders() {
else {
// Otherwise we only look at the sub-trees specified by the
// include paths.
- for (std::vector<std::string>::const_iterator I = IncludePaths.begin(),
- E = IncludePaths.end();
- I != E; ++I) {
- if (!collectFileSystemHeaders(*I))
+ for (const std::string &IncludePath : IncludePaths) {
+ if (!collectFileSystemHeaders(IncludePath))
return false;
}
}
diff --git a/clang-tools-extra/modularize/Modularize.cpp
b/clang-tools-extra/modularize/Modularize.cpp
index 7f8a19280b111..2a90c5e3f6782 100644
--- a/clang-tools-extra/modularize/Modularize.cpp
+++ b/clang-tools-extra/modularize/Modularize.cpp
@@ -339,8 +339,8 @@ static std::string findInputFile(const CommandLineArguments
&CLArgs) {
llvm::opt::Visibility VisibilityMask(options::CC1Option);
unsigned MissingArgIndex, MissingArgCount;
SmallVector<const char *, 256> Argv;
- for (auto I = CLArgs.begin(), E = CLArgs.end(); I != E; ++I)
- Argv.push_back(I->c_str());
+ for (const std::string &CLArg : CLArgs)
+ Argv.push_back(CLArg.c_str());
InputArgList Args = getDriverOptTable().ParseArgs(
Argv, MissingArgIndex, MissingArgCount, VisibilityMask);
std::vector<std::string> Inputs = Args.getAllArgValues(OPT_INPUT);
diff --git a/clang-tools-extra/modularize/ModularizeUtilities.cpp
b/clang-tools-extra/modularize/ModularizeUtilities.cpp
index 9ad1731915a8b..8a24f21d658df 100644
--- a/clang-tools-extra/modularize/ModularizeUtilities.cpp
+++ b/clang-tools-extra/modularize/ModularizeUtilities.cpp
@@ -69,8 +69,7 @@ ModularizeUtilities
*ModularizeUtilities::createModularizeUtilities(
// Load all header lists and dependencies.
std::error_code ModularizeUtilities::loadAllHeaderListsAndDependencies() {
// For each input file.
- for (auto I = InputFilePaths.begin(), E = InputFilePaths.end(); I != E; ++I)
{
- llvm::StringRef InputPath = *I;
+ for (llvm::StringRef InputPath : InputFilePaths) {
// If it's a module map.
if (InputPath.ends_with(".modulemap")) {
// Load the module map.
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
