alexfh added inline comments.
================ Comment at: lib/Tooling/CompilationDatabase.cpp:164 + // to user. + } else if (DiagLevel >= DiagnosticsEngine::Error) + Other.HandleDiagnostic(DiagLevel, Info); ---------------- Another couple of nits: 1. the comment below would probably be better moved to the body of the second `if` 2. enclose the next statement in braces. https://reviews.llvm.org/D33272 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits