[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

[Sanjay Patel via Phabricator via cfe-commits]

spatel added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:7932
       break;
     case X86::BI__builtin_ia32_cmppd256:
       ID = Intrinsic::x86_avx_cmp_pd_256;
----------------
1. Should we handle the 'pd256' version the same way?
2. How about the 0xb ('false') constant? It should produce a zero here?
3. Can or should we deal with the signalling versions (0x1b, 0x1f) too?



https://reviews.llvm.org/D33406



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits