DeinAlptraum wrote:

I've tested around a bit more and read up on the Github Actions docs, the 
takeaways are as follows
1. The reason that the libclang CI doesn't run is not that the file syntax is 
wrong (we'd still get a failed run complaining about syntax issues if that were 
the case). Rather, it seems that sometimes, workflows are not triggered if 
there's a conflict. Not that it matters right now since the workflow would fail 
with a syntax error anyway, but once we figured the problem out, you'll have to 
resolve the conflict for the CI to run.
2. `llvm-project-tests` is not an action, but a reusable workflow. It is not 
possible to add additional steps after calling a reusable workflow, so we'd 
have to either roll our own implementation to build the `libclang` cmake target 
in the CI, or change `llvm-project-tests` into an action so it can be used 
here. Imo the latter option is preferable, but as this also affects others 
using that workflow, I've opened a topic on Discourse to ask for feedback: 
https://discourse.llvm.org/t/github-actions-ci-should-the-llvm-project-tests-workflow-be-turned-into-an-action/87052

https://github.com/llvm/llvm-project/pull/142948
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to