https://github.com/dtcxzyw commented:

This patch eliminates many math libcalls that set `errno`. However, it causes 
some regressions when processing `llvm.memset`.
See the following pattern:
```
memset(p)
if (Cond) {
  memset(p);
  mem access with p
}
```
After this patch, the second memset is removed. However, `MemCpyOptPass` does 
better since it only removes the first one.

As `MemCpyOpt` handles memory intrinsics more precisely, can we bail out on 
memset here?



https://github.com/llvm/llvm-project/pull/145474
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to