Typz added a comment.

In https://reviews.llvm.org/D33447#763045, @djasper wrote:

> Does anything speak against making this behavior happen with 
> AllowShortFunctionsOnASingleLine = SFS_Empty and 
> MergeEmptyOnly.BraceWrapping.AfterFunction = true? I mean without the extra 
> style option?


That is fine with me (with `AllowShortFunctionsOnASingleLine >= SFS_Empty` 
condition), but I see two things:

- it does not match the "OnASingleLine" part of that option's name, since in 
that case we get the function definition on one line, and the body on the next 
line
- some (existing) coding style may use `BraceWrapping.AfterFunction` and 
`AllowShortFunctionsOnASingleLine` (for exemple Mozilla), but may not want to 
change the behavior when the function cannot be merged on a single line


https://reviews.llvm.org/D33447



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to