EricWF added a comment.

In https://reviews.llvm.org/D33080#754442, @compnerd wrote:

> I think that we should sink the `min`/`max` checks into `__undef_macros`.  I 
> don't like the idea of littering that check everywhere.


I would much rather litter at the cost of the implementation than needlessly 
include `__undef_macros` in every header; Especially because
it's almost always unneeded. I realize it's ugly internally but I think it's 
worth it. I'll attempt to write some compile time tests to ensure
I'm not making a mountain out of a molehill but could you also re-consider 
@compnerd?


https://reviews.llvm.org/D33080



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to