BillyONeal closed this revision.
BillyONeal added a comment.

In https://reviews.llvm.org/D33340#764206, @EricWF wrote:

> Sorry for the delay reviewing such a simple change.


No problem! Their simplicity also means no likely merge conflicts :)

In https://reviews.llvm.org/D33340#764213, @EricWF wrote:

> @BillyONeal Changes like this are good for post-commit review (ie just commit 
> it). Adding clearly correct assertions and test cases is never an 
> objectionable thing.


Sounds good, thanks!


https://reviews.llvm.org/D33340



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D33340: [l... Billy Robert O'Neal III via Phabricator via cfe-commits
    • [PATCH] D3334... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D3334... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D3334... Billy Robert O'Neal III via Phabricator via cfe-commits

Reply via email to