[clang] [clang-tools-extra] [clang][CodeComplete] skip explicit obj param in SignatureHelp (PR #146649)

[Mythreya Kuricheti via cfe-commits]

================
@@ -4435,11 +4444,11 @@ TEST(CompletionTest, SkipExplicitObjectParameter) {
     auto Result = codeComplete(testPath(TU.Filename), Code.point("c1"),
                                Preamble.get(), Inputs, Opts);
 
-    EXPECT_THAT(Result.Completions,
-                UnorderedElementsAre(AllOf(named("foo"), signature("(int 
arg)"),
-                                           snippetSuffix("(${1:int arg})")),
-                                     AllOf(named("bar"), signature("(int 
arg)"),
-                                           snippetSuffix("(${1:int arg})"))));
+    EXPECT_THAT(
+        Result.Completions,
+        UnorderedElementsAre(
+            AllOf(named("foo"), signature("(int arg)"), snippetSuffix("")),
+            AllOf(named("bar"), signature("(int arg)"), snippetSuffix(""))));
----------------
MythreyaK wrote:

potential regression?

https://github.com/llvm/llvm-project/pull/146649
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits